-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive the unique_id from the sensor name #56
base: dev
Are you sure you want to change the base?
Conversation
This leads to more "stable" unique_ids, not losing the history data after changing the friendly_name property in the configuration.
@Bouni this is surely a kind-of "breaking change" and will reset all existing history data for all luxtronik entities.. |
@remuslazar @BenPru I think from now on we should only work on a dev branch. No more changes to main until the merge (on is done. Once that is the case we can also apply the PR's and release a shiny new version that maybe breaking again but that hopefully for the last time (at least in a while). @remuslazar please rebase this to the dev branch |
@Bouni sorry for the long delay here.. I have somehow missed your request. Anyway, the code was already on top of the dev branch so I have just changed the base for this PR. btw: it will be nice to have a current release of luxtronik, this package being currently pinned to 0.3.14 which does not support new entities, e.g. Thanks! |
Hey @Bouni, Just wanted to check in and see if there's been any progress here. I am using my fork for quite a while now but I will like to integrate this integration via HACS. Let me know if I can help out with anything! Cheers, |
Unfortunately, no 🫤 |
@Bouni can I jump in and help you out here? |
This leads to more "stable" unique_ids, not losing the history data after changing the friendly_name property in
the configuration.