Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive the unique_id from the sensor name #56

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

remuslazar
Copy link
Contributor

This leads to more "stable" unique_ids, not losing the history data after changing the friendly_name property in
the configuration.

This leads to more "stable" unique_ids, not losing the history data
after changing the friendly_name property in
the configuration.
@remuslazar
Copy link
Contributor Author

@Bouni this is surely a kind-of "breaking change" and will reset all existing history data for all luxtronik entities..

@Bouni Bouni added the enhancement New feature or request label Dec 19, 2022
@Bouni
Copy link
Owner

Bouni commented Dec 19, 2022

@remuslazar @BenPru I think from now on we should only work on a dev branch. No more changes to main until the merge (on is done. Once that is the case we can also apply the PR's and release a shiny new version that maybe breaking again but that hopefully for the last time (at least in a while).

@remuslazar please rebase this to the dev branch

@remuslazar remuslazar changed the base branch from main to dev December 2, 2023 10:57
@remuslazar
Copy link
Contributor Author

@Bouni sorry for the long delay here.. I have somehow missed your request. Anyway, the code was already on top of the dev branch so I have just changed the base for this PR.

btw: it will be nice to have a current release of luxtronik, this package being currently pinned to 0.3.14 which does not support new entities, e.g. HUP_PWM I was trying to use recently. Could you do that, can I help somehow here?

Thanks!

@remuslazar
Copy link
Contributor Author

Hey @Bouni,

Just wanted to check in and see if there's been any progress here. I am using my fork for quite a while now but I will like to integrate this integration via HACS.

Let me know if I can help out with anything!

Cheers,
Remus

@Bouni
Copy link
Owner

Bouni commented Sep 27, 2024

Unfortunately, no 🫤
I have far to many side projects and to little spare time, so some things don't go forward as expected ...

@remuslazar
Copy link
Contributor Author

@Bouni can I jump in and help you out here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants